Jv increase throttle time for time error #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovalenti
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
This is a very large increase. But it will definitely lower the flood of logs, and we will still know that something is happening.
We could count the number of throttled occurrences ? (untested code) What do you think ?
Overall, looks good to me !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes the timestamp of an event is far in the past or in the future. There is logging to catch this. This logging is already throttled so that it does not flood the log. However, the logging is still too much. This makes it so that the frequency of the logging is reduced.
Checklist
- [ ] Updated documentation accordinglyAutomated testing
~~ - [ ] Added unit tests~~
~~ - [ ] Added integration tests~~
~~ - [ ] Added regression tests~~
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.